Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect implementation of Creation extension #92

Closed
richard-keller opened this issue Oct 21, 2018 · 0 comments
Closed

Incorrect implementation of Creation extension #92

richard-keller opened this issue Oct 21, 2018 · 0 comments
Assignees
Labels
Projects
Milestone

Comments

@richard-keller
Copy link

I've been trying to use tus-php to upload files to CloudFlare Stream. Eventually got it to work after much fiddling. Core to the problem seems to be that the tus-php client specifies its own upload filepath using the $key parameter, whereas this does not appear to be according to the protocol spec.

As per the Tus spec, on file creation, CloudFlare returns a Location header, which specifies the upload URL for the file. tus-php ignores this, and uses its own value of $key. This causes CloudFlare to fail the upload and return an internal server error.

When creating a new file, the server response is as follows:

HTTP/1.1 201 Created
Location: https://tus.example.org/files/24e533e02ec3bc40c387f1a0e460e216
Tus-Resumable: 1.0.0

The Location header should be the URL that is used for the PATCH request.

Reference: https://tus.io/protocols/resumable-upload.html

@ankitpokhrel ankitpokhrel self-assigned this Oct 21, 2018
@ankitpokhrel ankitpokhrel added this to the Unreleased milestone Oct 25, 2018
@ankitpokhrel ankitpokhrel added this to To Do in Kanban Oct 25, 2018
@ankitpokhrel ankitpokhrel moved this from To Do to In progress in Kanban Nov 4, 2018
@ankitpokhrel ankitpokhrel modified the milestones: 0.1.0, 1.0.0 Nov 17, 2018
Kanban automation moved this from In progress to Done Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Kanban
  
Done
Development

No branches or pull requests

2 participants