Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] The exclude_inherited option doesn't work anymore #242

Closed
GMartigny opened this issue Sep 12, 2023 · 7 comments · Fixed by #246
Closed

[Regression] The exclude_inherited option doesn't work anymore #242

GMartigny opened this issue Sep 12, 2023 · 7 comments · Fixed by #246

Comments

@GMartigny
Copy link
Contributor

Describe the bug

The exclude_inherited option was introduced in v3.4.0, but was reverted in v4.1.11 with commit 69ad4b6.

Does it was on purpose ? If yes, it should be removed from the options list.

@github-actions
Copy link

Wonderful, you have created your first issue for clean-jsdoc-theme. Someone will talk to you soon!

@ankitskvmdam
Copy link
Owner

Now, I realized why we should have a descriptive commit messages.

Unfortunately, I don't remember the reason why I removed it.

Do we want to have exclude_inherited option? If it is needed then we can revert the changes, else I will remove it from the option list.

@GMartigny
Copy link
Contributor Author

Do we want to have exclude_inherited option?

I personally would love to (as I was the author), but that's not for me to decide. It's not that big of a difference with the actual code, but one could argue that too many options.

@ankitskvmdam
Copy link
Owner

Sure, I will think give you an update on this by the end of this week. Thanks!

@ankitskvmdam
Copy link
Owner

Reverted changes.

@ankitskvmdam
Copy link
Owner

After doing this change: 785b638 in every page only constructor shows.

Could you add this feature again? For now I am reverting everything.

@GMartigny
Copy link
Contributor Author

You were just missing setting the variable in the publish.js file. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants