[PackageLoading] Always parse manifest when there are errors

<rdar://problem/53108485>
aciidgh · Jul 16, 2019 · 318fc16 · 318fc16
1 parent 22436df
commit 318fc16
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/Sources/PackageLoading/ManifestLoader.swift b/Sources/PackageLoading/ManifestLoader.swift
@@ -670,6 +670,14 @@ final class ManifestLoadRule: LLBuildRule {
         engine.taskNeedsInput(FileInfoRule.RuleKey(path: key.path), inputID: 3)
     }
 
+    override func isResultValid(_ priorValue: Value) -> Bool {
+        // Always rebuild if we had a failure.
+        let value = RuleKey.BuildValue(priorValue)
+        if value.hasErrors { return false }
+
+        return super.isResultValid(priorValue)
+    }
+
     override func inputsAvailable(_ engine: LLTaskBuildEngine) {
         let value = loader.parse(
             packageIdentity: key.packageIdentity,