Added Linux Support to Project #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurp
reviewed
Oct 24, 2016
| @@ -36,14 +39,14 @@ public class Regex { | |||
| } | |||
|
|
|||
| public class func escapeStr(str: String) -> String { | |||
| let matches = RegexPatternRegex.matches(testStr: str) | |||
| let matches = Regex(RegexEscapePattern).matches(testStr: str) | |||
There was a problem hiding this comment.
Why use this instead of RegexPatternRegex?
|
Thanks for the PR and will create a release once this is merged. Can you address my comment https://github.com/ankurp/Cent/pull/18/files/5c19b62077f28212e565122e05b8f053de198889#r84699225 |
|
@ankurp In response to your comment, I thought it was causing a separate issue. It turns out to be perfectly fine the way it was. |
|
I squashed your commits and merging it as part of this PR. Will create release soon. #19 |
|
@Bored0ne This is now published and tagged as version 6.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit rewrites a few functions and adds linux support to the project. If approved I also ask that you tag this and the Dollar project so that they can both be used on a linux system.