Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Signing issue with Dollar #150

Closed
bevbomb opened this issue May 1, 2015 · 11 comments
Closed

Code Signing issue with Dollar #150

bevbomb opened this issue May 1, 2015 · 11 comments

Comments

@bevbomb
Copy link

bevbomb commented May 1, 2015

I've had no issues with this before until the newest swift update, i've been uploading this project with this framework to the store with the same configuration for months now
failed library

@ankurp
Copy link
Owner

ankurp commented May 1, 2015

If its urgent can you try importing using submodule That way you will have more control over the signing by dragging the xcode project into your own workspace or project.

I will take a look at the code signing issue by publishing it to AppStore

@donnywals
Copy link

I have the same Issue and I imported Dollar by using it as a submodule..

@bevbomb
Copy link
Author

bevbomb commented May 2, 2015

I've always had it as a sub module and never had issues until now, I'm guessing the new Xcode might have left traces of a developers existing code signing, I just haven't at a change to look at it yet to see if there's duplicates

@donnywals
Copy link

I have solved my problems. Instead of using a submodule to include Dollar I've installed through Cocoapods. The Dollar.o file disappeared and my app is in TestFlight as we speak!

@ankurp
Copy link
Owner

ankurp commented May 2, 2015

I have added code sign to the project. Can someone try with Carthage again using latest code from master d029477

@tsuharesu
Copy link

Tried with the latest version of master (using Carthage) and still problematic

@bevbomb
Copy link
Author

bevbomb commented May 13, 2015

The only way I've managed to get this working is to use cocoa pods and use_frameworks!

@tsuharesu
Copy link

Any updates on this?

@ankurp
Copy link
Owner

ankurp commented May 19, 2015

This is something hard for me to replicate as it doesn't throw the same error for me for code signing as I am the person making the library and also publishing the app. This happens only when publishing the app so someone with expertise in this might be able to help out. If someone know the configuration that works for all I am willing to try that.

@tsuharesu
Copy link

You could try using the same config as Alamofire? I don't know if it is already equals
https://github.com/Alamofire/Alamofire/blob/master/Alamofire.xcodeproj/project.pbxproj

@simonyangme
Copy link
Contributor

I've opened a PR fixing this issue. It's a problem with including code in the copy bundle resources build phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants