Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think a pull request template is needed to review Pull request more effectively and efficiently. #46

Closed
kumarshobhit opened this issue Dec 3, 2020 · 2 comments
Closed

I think a pull request template is needed to review Pull request more effectively and efficiently. #46

kumarshobhit opened this issue Dec 3, 2020 · 2 comments

Comments

@kumarshobhit
Copy link

No description provided.

@kumarshobhit kumarshobhit changed the title I feel that under NJACK, there will be a lot of PRs on this project. So a pull request template would help the maintainer to review Pull request more effectively and efficiently. I think a pull request template is needed to review Pull request more effectively and efficiently. Dec 3, 2020
@ankushbhardwxj
Copy link
Owner

Firstly, you should give proper heading when filing an issue. You can describe it in the comments, but the header should be straightforward and short.
And as a maintainer, I'm okay, without a pull request template since the project is not quite huge at the moment. Thanks ! Closing this issue for now.

@kumarshobhit
Copy link
Author

Ok noted. Thanks for the insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ankushbhardwxj @kumarshobhit