Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for "codemon fetch" #66

Closed
ankushbhardwxj opened this issue Dec 9, 2020 · 2 comments · Fixed by #72
Closed

Improvements for "codemon fetch" #66

ankushbhardwxj opened this issue Dec 9, 2020 · 2 comments · Fixed by #72
Labels
enhancement New feature or request help wanted Extra attention is needed HIGH-POINTS

Comments

@ankushbhardwxj
Copy link
Owner

  • When inputs and outputs are written in the .in and .op files, there's an additional newline at the top of each file, which can cause problems in diffing between outputs during codemon listen, therefore, we need to avoid adding that newline either during write or be remove post write.
  • Improve all verbose messages and use consistent coloring, currently, some of them are green and some are yellow, in a very inconsistent way. Maybe stick to white or some other bright colour which will be good for a basic terminal.
  • Maybe get rid of codemon fetch <contestName> ? This needs discussion. Currently there are 3 ways to leverage the fetching functionality: codemon fetch inside contest directory, codemon init -f <contestdir>, codemon fetch <contestName>. The last one creates a directory with given contest name and contains only inputs and outputs and no code files. I believe we have already served that purpose with codemon init -f <contestDir>, therefore we can get rid of this command.
@Enigmage
Copy link
Contributor

Enigmage commented Dec 10, 2020

@ankingcodes I agree, the command does seem redundant to the current functionality. I think we should remove it. There are also a few inconsistencies in CodemonFetch module that I want to fix. I'll make a new PR for all this.

As for the second one I think it can be a separate issue, make coloring of all verbose messages consistent and also add better verbose messages for a better user experience. What do you think?

@ankushbhardwxj
Copy link
Owner Author

@Enigmage - Yeah, I agree with this. But I'm not a big fan of long messages. Make them verbose wherever required, but try to keep them concise and to the point.

@ankushbhardwxj ankushbhardwxj added enhancement New feature or request help wanted Extra attention is needed HIGH-POINTS labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed HIGH-POINTS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants