Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example pulling github.com/flynn/go-shlex #4

Closed
orgrim opened this issue May 13, 2020 · 1 comment
Closed

example pulling github.com/flynn/go-shlex #4

orgrim opened this issue May 13, 2020 · 1 comment

Comments

@orgrim
Copy link

orgrim commented May 13, 2020

Hello,

By using your module, I've found that github.com/flynn/go-shlex gets pulled as dependency. It is because it is used in the example_test.go file, but not required.

Would putting it in a examples/ subdirectory and updating go.mod avoid that?

Thanks and regards

@anmitsu
Copy link
Owner

anmitsu commented May 14, 2020

I also think module dependency for comparative example is not desirable.

And because github.com/flynn/go-shlex is not updated for a long time, I remove this pkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants