Skip to content

Commit

Permalink
fix(form): ensure that the Form component does not verify hidden form…
Browse files Browse the repository at this point in the history
… items
  • Loading branch information
anncwb committed Mar 7, 2021
1 parent e0dc5cf commit 43a45b7
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.zh_CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- `BasicTree` 新增`clickRowToExpand`,用于单击树节点展开
- 新增 SvgIcon 插件及示例
- 账号管理界面增加左侧部门树

### ⚡ Performance Improvements

Expand All @@ -22,6 +23,7 @@
- 修复账号管理新增未清空旧数据
- form 组件应允许 setFieldsValue 方法值为 null 或者 undefined
- 确保单级面包屑正确跳转
- 确保 Form 组件不校验隐藏的表单项

## 2.0.2 (2021-03-04)

Expand Down
6 changes: 5 additions & 1 deletion src/components/Form/src/components/FormItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export default defineComponent({
return disabled;
});

function getShow() {
function getShow(): { isShow: boolean; isIfShow: boolean } {
const { show, ifShow } = props.schema;
const { showAdvancedButton } = props.formProps;
const itemIsAdvanced = showAdvancedButton
Expand Down Expand Up @@ -151,6 +151,10 @@ export default defineComponent({
const { rulesMessageJoinLabel: globalRulesMessageJoinLabel } = props.formProps;
if (requiredRuleIndex !== -1) {
const rule = rules[requiredRuleIndex];
const { isShow } = getShow();
if (!isShow) {
rule.required = false;
}
if (rule.required && component) {
if (!Reflect.has(rule, 'type')) {
rule.type = 'string';
Expand Down
1 change: 1 addition & 0 deletions src/components/Form/src/hooks/useFormEvents.ts
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ export function useFormEvents({
async function validateFields(nameList?: NamePath[] | undefined) {
return unref(formElRef)?.validateFields(nameList);
}

async function validate(nameList?: NamePath[] | undefined) {
return await unref(formElRef)?.validate(nameList);
}
Expand Down
2 changes: 1 addition & 1 deletion src/views/demo/system/account/account.data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const accountFormSchema: FormSchema[] = [
label: '密码',
component: 'InputPassword',
required: true,
show: true,
show: false,
},
{
label: '角色',
Expand Down

0 comments on commit 43a45b7

Please sign in to comment.