-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BetterPolygon: handle deletion conflicts with annotation deletion #28
Comments
Thank you ! I will look closely the upcoming fixes :) |
Works fine for the point deletion thank you :) When I try to delete a point from a triangle the whole selection is deleted and the problem from annotorious/annotorious#221 comes back. I don't know if this is intended but maybe the fact that when there are two points remaining, the selection is completely deleted should be documented. |
Argh - yes, of course. It shouldn't delete on triangles, because that would (essentially) create an invalid polygon. I didn't test for that case... I think the desired behavior would be to simply do nothing, i.e. not delete the point; but don't delete the polygon either. What do you think? (Meanwhile, I'll re-open the ticket.) |
Hi, I would like to handle both deletion of an handle and the deletion of the whole selection but they conflict with each others. The solution I am thinking of is testing if an handle is selected when delete action is caught and ignore selection deletion to let BetterPolygon catch the delete event. The problem is that I don't know how to access if an handle is selected from the
Annotorious
object. Is there a way to access it ?The text was updated successfully, but these errors were encountered: