Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point tool not working on touch #21

Open
rsimon opened this issue Jan 23, 2023 · 7 comments
Open

Point tool not working on touch #21

rsimon opened this issue Jan 23, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@rsimon
Copy link
Member

rsimon commented Jan 23, 2023

Seems completely broken for Annotorious standard, and partially broken in the OpenSeadragon version. In OSD it's possible to create a point. But it's not possible to move the point after creating.

@rsimon rsimon added the bug Something isn't working label Jan 23, 2023
@RomainDECOSTER
Copy link

Hello,

Do you have a solution to this problem? I used the point tool, but I cannot edit or move it.

I found a workaround:

if (tool === "point") {
     anno.current.on("mouseEnterAnnotation", (annotation: any) => {
        anno.current.selectAnnotation(annotation);
      });
}

So now I can edit bodies, but I cannot move them.

@rsimon
Copy link
Member Author

rsimon commented Mar 21, 2024

I'm afraid not. It's probably not a huge issue to fix, but I don't currently have the bandwidth/spare time to spend at the moment.

@RomainDECOSTER
Copy link

I can try to fix it. Do you have any idea where I should start?

@rsimon
Copy link
Member Author

rsimon commented Mar 21, 2024

Not really sure... but the starting point is probably somewhere in the tool base classes:
https://github.com/annotorious/annotorious/tree/2.x/src/tools

Also see here for how to set up the dev stack:
https://annotorious.github.io/guides/hackers-guide/

@RomainDECOSTER
Copy link

Alright, I've tested it on a new fresh project.
I didn't encounter any bugs with the point tool: Simple point tool
I can create, update, and move points without issues.

In my case, I forgot to add renderedVia: { name: "point" }, when loading my annotations.

I believe you can close this bug; it works great in version 2.X.

@rsimon
Copy link
Member Author

rsimon commented Mar 21, 2024

Great, thanks! Did you test this on touch devices?

@RomainDECOSTER
Copy link

Yes tested, it's not works on touche devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants