Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve per-module compilation by checking modification time #2680

Closed
lukaszcz opened this issue Mar 7, 2024 · 1 comment
Closed

Improve per-module compilation by checking modification time #2680

lukaszcz opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@lukaszcz
Copy link
Collaborator

lukaszcz commented Mar 7, 2024

Currently, when checking whether a module should be recompiled we always compute the hash of the source and compare with the stored hash. We could also store the modification time, assume the source hasn't changed if the modification time didn't change and compute the source hash only if it did change. This would speed up stored module loading.

@lukaszcz lukaszcz added this to the 0.6.1 milestone Mar 7, 2024
@lukaszcz lukaszcz self-assigned this Mar 7, 2024
@paulcadman paulcadman modified the milestones: 0.6.1, 0.6.2 Mar 25, 2024
@lukaszcz lukaszcz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
@lukaszcz
Copy link
Collaborator Author

No significant performance improvement is achieved by checking modification time. The ~1s loading time for compiled standard library is due to deserialization of the saved compiled modules, not due to hash computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants