Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to read the prev value for batch delete #1116

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Feb 3, 2023

When deleting keys with a batch in the write log commit, the diffs weren't written to the DB

closes #77

@yito88 yito88 changed the title Fix to read the prev value for delete Fix to read the prev value for batch delete Feb 3, 2023
tzemanovic
tzemanovic previously approved these changes Feb 6, 2023
tzemanovic
tzemanovic previously approved these changes Feb 7, 2023
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the test!

@tzemanovic
Copy link
Member

@yito88 pls add a changelog entry

tzemanovic added a commit that referenced this pull request Apr 7, 2023
* yuji/fix_batch_delete_subspace_val:
  add a changelog
  add unit tests
  fix to read the prev value
@tzemanovic tzemanovic mentioned this pull request Apr 7, 2023
@juped juped merged commit 0336672 into main Apr 13, 2023
@juped juped deleted the yuji/fix_batch_delete_subspace_val branch April 13, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase code coverage for ledger/storage/rocksdb.rs
3 participants