Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate IBC and wrapped ERC20 multitoken handling code #735

Closed
james-chf opened this issue Nov 4, 2022 · 3 comments
Closed

Consolidate IBC and wrapped ERC20 multitoken handling code #735

james-chf opened this issue Nov 4, 2022 · 3 comments
Assignees
@yito88
Labels
ethereum-bridge refactor / code quality

Comments

@james-chf
Copy link
Contributor

No description provided.

@cwgoes
Copy link
Contributor

cwgoes commented Jan 14, 2023

cc @yito88 can we possibly merge these two implementations?

@james-chf
Copy link
Contributor Author

To add some context (I should have added when opening the issue) - there are some helper functions used by ERC20 code defined in core/src/ledger/eth_bridge/storage/wrapped_erc20s.rs (e.g. sub_prefix fn) that could probably be replaced/merged with multitoken helper functionality in core/src/types/token.rs

@sug0
Copy link
Contributor

sug0 commented Jul 11, 2023

Closed by #1693

@sug0 sug0 closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yito88 yito88

Labels
ethereum-bridge refactor / code quality
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sug0 @yito88 @cwgoes @james-chf