Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm module #11

Closed
gagan-bansal opened this issue May 22, 2015 · 3 comments
Closed

npm module #11

gagan-bansal opened this issue May 22, 2015 · 3 comments

Comments

@gagan-bansal
Copy link
Contributor

Very nice lib, I am using it in many applications.
Now I require it with browserify ie. as commanjs module. Would you please consider it publishing on npm?

@anomal
Copy link
Owner

anomal commented May 23, 2015

I am unclear on what I need to add to make it a CommonJS module, and how to publish it to npm as "rainbowvis.js" (as npm does not allow capital letters (?)) without breaking the existing URL https://raw.githubusercontent.com/anomal/RainbowVis-JS/master/rainbowvis.js.

Please advise.

@gagan-bansal
Copy link
Contributor Author

Please go through this blog that explains how to make a module and publish it on npm and read more on npm documentation
The URL for rainbowvis.js is not used in npm, as it is a separate echo system. Though you should mention the github repo URL in package.json.

Anyway this url can not be consumed directly from github, as github does not allow hotlinking. You can use some alternate or cdn server.

If any issue please let me know. such a nice library should be exposed to more users.
Later you should also consider test cases for this lib.

@anomal
Copy link
Owner

anomal commented May 24, 2015

Thanks for forking.

I had an ad-hoc script that hotlinked to github years ago. I did not know they disabled hotlinking now.

@anomal anomal closed this as completed May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants