Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix currency_format #350

Closed
wants to merge 1 commit into from
Closed

fix currency_format #350

wants to merge 1 commit into from

Conversation

huglester
Copy link
Contributor

With old formating in place, you will have ambigous numbers.
not sure why it is needed at all here.

we format value, add prefix/suffix and thats it!

thanks

With old formating in place, you will have ambigous numbers.
not sure why it is needed at all here.

we format value, add prefix/suffix and thats it!

thanks
@RyanThompson
Copy link
Contributor

Can you explain "ambigous numbers"?

The purpose is to take 10.013 and convert to 10.01 and 10.377 to 10.38

@RyanThompson
Copy link
Contributor

I am going to close this for now and wait to get some heavy real world testing. I don't like the string thing (also it returns a string) also. Might revisit but I need more experience with it / proof of concepts for the two approaches.

@stefanpkc
Copy link

I don't want to reopen this, but just for when this takes off again, there's an argument not to use floats or decimals at all. Only for presenting/printing out values you divide by 100 to get the decimals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants