Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination added for my files page #44

Merged
merged 5 commits into from Oct 11, 2022
Merged

Conversation

detronetdip
Copy link
Contributor

@detronetdip detronetdip commented Oct 2, 2022

I have added pagination system in My Files page.

Fixes #2

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@detronetdip
Copy link
Contributor Author

@anomic30 please review it.

@anomic30
Copy link
Owner

anomic30 commented Oct 3, 2022

@Sneakad, check the UI. It looks like this:

image

@anomic30 anomic30 added enhancement New feature or request hacktoberfest labels Oct 3, 2022
@Sneakad
Copy link
Collaborator

Sneakad commented Oct 3, 2022

@detronetdip can you put the numbers in boxes? For example, if the user is on the second page then the selected box bg will be solid other boxed will only have border-radius.
image

@detronetdip
Copy link
Contributor Author

Sure why not

@detronetdip
Copy link
Contributor Author

@Sneakad please check once

@anomic30
Copy link
Owner

anomic30 commented Oct 3, 2022

@detronetdip, show us the ss here.

@detronetdip
Copy link
Contributor Author

Screenshot from 2022-10-03 23-38-46

@detronetdip
Copy link
Contributor Author

@anomic30 as it is showing conflicts with base branch should I resolve it by merging the base base branch?

@anomic30
Copy link
Owner

Hi, @detronetdip, each page should show at least 8 files.
Pull the latest changes from the main branch, resolve conflicts.

@detronetdip
Copy link
Contributor Author

@anomic30 done

Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anomic30 anomic30 merged commit 069a78c into anomic30:main Oct 11, 2022
@anomic30 anomic30 added the hacktoberfest-accepted Accepted for Hacktoberfest 2022 label Oct 11, 2022
@Sneakad Sneakad changed the title Pagignation added for my files page Pagination added for my files page Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination in My Files page
3 participants