Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance file section when file name is too big #64

Merged
merged 3 commits into from Oct 7, 2022

Conversation

nujovich
Copy link

@nujovich nujovich commented Oct 4, 2022

Description

The application now will have an enhanced user experience while navigating through Files Section when the file name is too large

Mobile:

image

image

Desktop:

image

image

Even when the file name is not that large, for mobile devices the Ellipsis truncation is done for better visualization:

image

Fixes #56

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@anomic30
Copy link
Owner

anomic30 commented Oct 4, 2022

Hi @nujovich, as you can see these are not aligned:
image

@nujovich
Copy link
Author

nujovich commented Oct 4, 2022

Hi @nujovich, as you can see these are not aligned:
image

Oops ! Nice catch. Let me work on that.

@anomic30
Copy link
Owner

anomic30 commented Oct 6, 2022

Hi @nujovich, is it fixed now?

@nujovich
Copy link
Author

nujovich commented Oct 6, 2022

Hi @anomic30! I haven't had the chance to look at it. I will upload the fix shortly. Will let you know as soon as the commit is made

@nujovich
Copy link
Author

nujovich commented Oct 7, 2022

Now's looking better @anomic30 !

image

Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anomic30 anomic30 added bug Something isn't working hacktoberfest-accepted Accepted for Hacktoberfest 2022 hacktoberfest labels Oct 7, 2022
@anomic30 anomic30 merged commit 3b19193 into anomic30:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]- Enhance navigation on Files section when file name is too big
2 participants