some optimizations?

[leeoniya]

@anonrig

fast-querystring/lib/parse.js

Lines 44 to 45 in 212c51c

	key = key.replace(/\+/g, " ");
	value = value.replace(/\+/g, " ");

.replaceAll('+', ' ') is probably faster than the regex variant.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll

fast-querystring/lib/parse.js

Line 27 in 212c51c

if (c === 38 || isNaN(c)) {

Number.isNaN() is more robust

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN

[anonrig]

Hey @leeoniya

Thank you for the issue!

• replaceAll vs replace with regex

You are absolutely right. I did a benchmark and it seems regex is 80% slower. I would appreciate if you can open a pull request to change this!

• Number.isNaN vs isNaN

I believe Number.isNaN is slower than isNaN, due to the type check. A quick benchmark showed that Number.isNaN is 0.17% slower on Safari, and 0.01% slower on Chrome. I think it's negligible in terms of performance. Therefore, would you open a pull request for this?

[Uzlopak]

I proposed #2 which actually avoids the whole isNaN issue.