Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Master-Passwords with spaces #3

Closed
Christoph-AK opened this issue Oct 15, 2020 · 3 comments
Closed

Fix for Master-Passwords with spaces #3

Christoph-AK opened this issue Oct 15, 2020 · 3 comments

Comments

@Christoph-AK
Copy link

My Master-Password with spaces didn't get accepted.

Enclosing the password in double quotes by changing line 268 in bw-at.ahk to

login := "login " bwUser " """ bwPass """"

does fix the problem for me.

@anonymous1184
Copy link
Owner

You're right, never tested spaces since back in the day services I used regularly didn't accepted spaces (I remember Usenet, IRC and ICQ), thus for me, the space was kind of a "forbidden" character in passwords. Now, I have a function (CNG based) to generate passwords from all the ASCII printable characters (33 to 126).

Thanks a lot for your input. However I can't do it right now and it still needs to validate quotes and properly escape them. I guess it'll be something along the lines of:

    quote := Chr(34)
    if (InStr(bwPass, quote))
    {
        bwPass := StrReplace(bwPass, quote, quote quote)
    }
    login := "login " bwUser A_Space quote bwPass quote

@Christoph-AK
Copy link
Author

Christoph-AK commented Oct 16, 2020

the space was kind of a "forbidden" character in passwords.

That is why I like to use the thing in passwords so much, most people wouldn't think of trying it out and it makes for easy to remember, but long passwords 😄

Thanks for developing this!

@anonymous1184
Copy link
Owner

Latest release takes care of this an much more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants