Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/Improve tests #184

Closed
sammcj opened this issue Sep 14, 2022 · 4 comments
Closed

Add/Improve tests #184

sammcj opened this issue Sep 14, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sammcj
Copy link
Collaborator

sammcj commented Sep 14, 2022

We should add and improve the tests to cover more failure scenarios / known working configuration patterns.

We should test to cover things like:

etc....
@sammcj sammcj added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 14, 2022
@sammcj
Copy link
Collaborator Author

sammcj commented Oct 4, 2022

@sbe-arg this is needed more than ever 🤣

@sbe-arg
Copy link
Collaborator

sbe-arg commented Oct 4, 2022

Yeah hahaha, We need some sort of current schema config so we can compare input with desired outputs.

@sammcj sammcj pinned this issue Oct 4, 2022
This was referenced Jan 5, 2023
Merged
Open
@L-Sypniewski
Copy link

#102 adds some tests, maybe it covers enough scenarios to resolve this?

@sammcj
Copy link
Collaborator Author

sammcj commented Apr 1, 2023

I think it'd be good to have a separate PR for adding general / current tests as looking at that PR there's been some back and forth and it's rather large - which is risky to merge... without better tests 😄

@sbe-arg sbe-arg closed this as completed Jun 20, 2023
@sbe-arg sbe-arg unpinned this issue Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sammcj @sbe-arg @L-Sypniewski