Hard coded branch name for getting full git history results in broken action

[TobiWo]

Here you hard code master as branch to check for full history. However, if your main branch is called main or differently this will not work. You have multiple options:

• add a new environment variable where the user set's the name of the main branch
• maybe use the already present RELEASE_BRANCHES env variable but this is maybe a bit greedy ... I mean how to decided which is the main branch if multiple release branches are defined
• or you extract the default branch (see here) assuming that this is the users main/master which should be the case

For reference: https://github.com/TobiWo/eth-duties/actions/runs/3765394398/jobs/6400825949#step:4:33

[sbe-arg]

Good point @sammcj mind opening a hotfix pr I'm on holidays without access to a laptop

Maybe we can set it to something like

${{ github.event.repository.default_branch }}

And apologies

[sbe-arg]

Oh wait I see what you mean this breaks the
Full history Line 130 master..HEAD

[sbe-arg]

Did this over the phone needs testing before merging

#230

[sbe-arg]

hotfix merged @TobiWo can you test 1.56 and re-open if the problem persists

[TobiWo]

I will test it. Thanks.

[TobiWo]

hotfix merged @TobiWo can you test 1.56 and re-open if the problem persists

Hi @sbe-arg, I tested the new release but still have some issues.

1. If I rebase and merge the action doesn't recognize any commit with BRANCH_HISTORY: full (see here)
2. If I rebase and merge everything works as expected with BRANCH_HISTORY: last (see here)
3. If I use a regular merge commit I receive a similar error as before the fix (see here)

I'm not able to re-open the issue (maybe I don't see how or I don't have permissions). In any way this needs some fix.
It would be nice if the full commit history can be considered also on rebase and merge. I like to use the rebase approach and I always need to check the last commit message for the respective keyword currently which is a bit cumbersome.

P.S.: I'm not able to re-open because you closed it 😉

[sbe-arg]

Reopened for tracking...

Its been looked in combination to fixing the history and default branch setting.

They both depend on each other depending the type of history and the alpine container has no head but workarounds are comming.

[sbe-arg]

Tracking in #243