Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezing while deconstructing roboports on big bot based map #3

Closed
Danielv123 opened this issue Aug 17, 2015 · 6 comments
Closed

Freezing while deconstructing roboports on big bot based map #3

Danielv123 opened this issue Aug 17, 2015 · 6 comments

Comments

@Danielv123
Copy link

I have a big map (14 mb) completelly bot based. Whenever I try to remove one of my roboports, no matter if it is connected to a network or not, it freezes for 5-10 seconds. I have tried removing other mods and this mod ended up being the problem. Using version 0.2.4

@anoutsider
Copy link
Owner

it's probably the disconnected chests check loop that is causing it, would it be possible for you to send me the save?

i'd like to run some test and hopefully a fix.

@Danielv123
Copy link
Author

Uploading now with all the mods I am using included. Game dies if removing some of them, but you should be able to figure it out. Save name is moded-economy.zip

Edit: added link: https://mega.nz/#!1c81kLbZ!FTd_bIvVxDz9-9nW1x_PLzWGaIpggH0X8yAlx9jv8Fk
This upload is without waitex as it shouldn't have any impact on gameplay.

@Rseding91
Copy link

Just an FYI: you can drastically improve the performance (and simplicity of the code) on all aspects by using the new LogisticNetwork and LogisticCell interfaces added recently:

http://www.factorioforums.com/wiki/index.php?title=Lua/LogisticNetwork
http://www.factorioforums.com/wiki/index.php?title=Lua/LogisticCell

@anoutsider
Copy link
Owner

@Rseding91 Wow this is amazing! i was knee deep working on a sweep line algorithm to better calculate the network.. and it's been tough :)

This is a life saver, thank you for pointing it out and for the awesome work on the api.

@anoutsider
Copy link
Owner

Latest release 0.2.6 should fix your issue, personally tested it with your save and seems to be running smoothly.

  • sorry for the delay

@Danielv123
Copy link
Author

Thanks for fixing it, delay won't be a problem as I can't start playing again before december.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants