Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height auto #21

Closed
fabiiomiiguel opened this issue Jan 17, 2021 · 3 comments
Closed

Height auto #21

fabiiomiiguel opened this issue Jan 17, 2021 · 3 comments

Comments

@fabiiomiiguel
Copy link

This is how gantt stays if we don't set the height.

image

I could put height auto, simply using:

.sg-timeline-body { flex: 0 1 auto !important; }

image

Maybe should be something to include by default, or maybe using an optional prop.

@ANovokmet
Copy link
Owner

Does your container element have a defined height?

@fabiiomiiguel
Copy link
Author

Nop the container is only display: flex; flex-direction: horizontal, and with that css on sg-timeline-body we don't need to set any height, I think that could be nice feature

ANovokmet added a commit that referenced this issue Feb 2, 2021
@ANovokmet
Copy link
Owner

ANovokmet commented Feb 2, 2021

I've tested this in a new project. Changed sg-timeline-body flex: 1 1 0 to flex: 1 1 auto, which will prevent it from having a 0 height.

Thank you @fabiiomiiguel for finding and reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants