Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RowModel Types #77

Closed
aliyss opened this issue May 24, 2022 · 1 comment
Closed

RowModel Types #77

aliyss opened this issue May 24, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@aliyss
Copy link

aliyss commented May 24, 2022

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

In my opinion the types I'm using seem to be working.
I'm not sure about the id. Afaik it can be a string too.

label is defined in the README but missing in the interface.
height works fine without providing it. So I will assume it's optional.

Aliyss

Here is the diff that solved my problem:

diff --git a/node_modules/svelte-gantt/types/core/row.d.ts b/node_modules/svelte-gantt/types/core/row.d.ts
index a2469e2..5e65ca3 100644
--- a/node_modules/svelte-gantt/types/core/row.d.ts
+++ b/node_modules/svelte-gantt/types/core/row.d.ts
@@ -1,9 +1,10 @@
 export interface RowModel {
-    id: number;
+    id: number | string;
+    label: string;
     classes?: string | string[];
     contentHtml?: string;
     enableDragging?: boolean;
-    height: number;
+    height?: number;
     /** Child rows in expandable tree */
     children?: RowModel[];
     /** Content of row header, html string */
@V-Py
Copy link
Collaborator

V-Py commented May 29, 2022

Basically your issue is a pull request ? 馃槃 I'll look into it and integrate it asap

@V-Py V-Py added enhancement New feature or request bug Something isn't working labels May 29, 2022
@V-Py V-Py closed this as completed in 83a36d1 May 30, 2022
V-Py added a commit that referenced this issue May 30, 2022
fix #77 RowModel interface adjustements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants