Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow breaking ABI by default #25

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Do not allow breaking ABI by default #25

merged 1 commit into from
Apr 18, 2018

Conversation

ansasaki
Copy link
Owner

Removed '--care' option and added '--allow-abi-break'. Symbols are not
removed and an Exception is raised if any symbol is removed and
'--allow-abi-break' is not used.

Removed '--care' option and added '--allow-abi-break'. Symbols are not
removed and an Exception is raised if any symbol is removed and
'--allow-abi-break' is not used.
@codecov-io
Copy link

codecov-io commented Apr 18, 2018

Codecov Report

Merging #25 into master will increase coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   88.85%   89.42%   +0.57%     
==========================================
  Files           2        2              
  Lines         700      700              
  Branches      181      181              
==========================================
+ Hits          622      626       +4     
+ Misses         41       38       -3     
+ Partials       37       36       -1
Impacted Files Coverage Δ
src/symbol_version/symbol_version.py 89.36% <100%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0062ee...b8b78fd. Read the comment docs.

@coveralls
Copy link

coveralls commented Apr 18, 2018

Pull Request Test Coverage Report for Build 39

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 91.439%

Totals Coverage Status
Change from base Build 37: 0.4%
Covered Lines: 662
Relevant Lines: 700

💛 - Coveralls

@ansasaki ansasaki merged commit 1c6bff7 into master Apr 18, 2018
@ansasaki ansasaki deleted the no_abi_break branch April 18, 2018 12:22
@ansasaki
Copy link
Owner Author

Fixes #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants