-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use timeout when waiting for second Vol button action #19
Comments
@ronso0 Thanks for the suggestion. Will look into this enhancement. Sorry for the late reply |
Same on my device, just to confirm. Though after turning on, I can disable it by pressing the first button again. |
@OffifialMITX @ronso0 This issue is fixed with Torchie 3.2 release. Can you confirm with the latest version in Google Play Store? |
I'll wait for the F-Droid release but thanks for the heads up. |
I don't use the playstore anymore, either. is there some CI where I can pick up build artifacts/apks? |
Thx you worked on it! |
Torchie turns on when I press both Vol buttons at once.
Though, 'at once' rarely is true, there's always a tiny delay between the two button actions.
Which turns out to be feature, because to toggle your LED:
you can slide over the Vol rocker in any direction
you can press/release both buttons discretely one after the other, which increases accessibility IMO
..but also a bug:
on my device, Torchie appears to wait more than 2min for that second button press, and the LED turned on unnoticed in my pocket quite a few times...and sometimes I could not toggle the LED afterwards
Reproduce:
make sure Torchie is turned off
lock screen, screen off
press
Vol +
wait up to 2 minutes
press
Vol -
I think a timeout of a few seconds would fix the bug and also keep the accessibility feature.
htc desire x
android 4.1.2
aokp-1.0
The text was updated successfully, but these errors were encountered: