Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prévoir l'évolution du nouvel IG FrCore #195

Open
nriss opened this issue Nov 21, 2023 · 20 comments · May be fixed by #345
Open

Prévoir l'évolution du nouvel IG FrCore #195

nriss opened this issue Nov 21, 2023 · 20 comments · May be fixed by #345
Assignees
@sdemeyANS
Labels
enhancement New feature or request
Milestone
tbd

Comments

@nriss
Copy link
Member

nriss commented Nov 21, 2023

Description du problème

Des travaux sont en cours côté InteropSanté pour publier un IG FrCore. Il faudra mettre à jour l'héritage une fois publié.
https://github.com/Interop-Sante/hl7.fhir.fr.core
@sdemeyANS sdemeyANS self-assigned this Nov 21, 2023
@sdemeyANS sdemeyANS added this to the tbd milestone Nov 21, 2023
@sdemeyANS sdemeyANS added the enhancement New feature or request label Nov 21, 2023
@sdemeyANS sdemeyANS mentioned this issue Dec 5, 2023
Closed
@sdemeyANS
Copy link
Collaborator

attente publication nouvel IG FR.core

@sdemeyANS
Copy link
Collaborator

sdemeyANS commented Apr 3, 2024 •
edited
Loading

1ers impacts en modifiant juste la version fr.core en dépendance:

  1. changement URL canonique exemple http://interopsante.org/fhir/StructureDefinition/FrOrganization devient https://hl7.fr/ig/fhir/core/StructureDefinition/fr-core-organization
  2. changement id des ressources : exemple fr-organization devient fr-core-organization

@sdemeyANS
Copy link
Collaborator

sdemeyANS commented Apr 3, 2024 •
edited
Loading

  • changement id fr-organization => fr-core-organization

@sdemeyANS
Copy link
Collaborator

nouvelles erreurs:
error Slice named idNatSt already exists on element Organization.identifier of ROROrganization
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 39 - 46
error Slice named finess already exists on element Organization.identifier of ROROrganization
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 39 - 46
error Slice named sirene already exists on element Organization.identifier of ROROrganization
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 39 - 46
error Slice named rppsRang already exists on element Organization.identifier of ROROrganization
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 39 - 46
error Slice named adeliRang already exists on element Organization.identifier of ROROrganization
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 39 - 46
error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#40 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"IDNST"}]}.
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 49
error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203".
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 54
error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203".
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 59
error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#4 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}.
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 64
error Cannot assign "http://rppsrang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://rppsrang.esante.gouv.fr/".
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 65
error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#0 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}.
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 80
error Cannot assign "http://adelirang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://adelirang.esante.gouv.fr/".
File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh
Line: 81

@sdemeyANS
Copy link
Collaborator

sdemeyANS commented Apr 3, 2024 •
edited
Loading

nouvelles erreurs: error Slice named idNatSt already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named finess already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named sirene already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named rppsRang already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named adeliRang already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#40 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"IDNST"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 49 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 54 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 59 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#4 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 64 error Cannot assign "http://rppsrang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://rppsrang.esante.gouv.fr/". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 65 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#0 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 80 error Cannot assign "http://adelirang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://adelirang.esante.gouv.fr/". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 81

  • supprimer slice déjà définie dans fr.core
  • warning changement http https dans les uri => impact en dev
  • analyse autre impact dev ? slice vraiment identique?

@sdemeyANS
Copy link
Collaborator

  • supprimer slice déjà définie dans fr.core
  • warning changement http https dans les uri => impact en dev
  • analyse autre impact dev ? slice vraiment identique?

sushi OK

@sdemeyANS
Copy link
Collaborator

sdemeyANS commented Apr 3, 2024 •
edited
Loading

@sdemeyANS
Copy link
Collaborator

  • supprimer slice déjà définie dans fr.core

par contre slice fr.core moins complète que celle du ROR : Interop-Sante/hl7.fhir.fr.core#151

@nriss
Copy link
Member Author

nriss commented Apr 3, 2024

Je pense que le niveau de complétude est le même, j'ai juste défini une slice pour dire les deux types de numéros

@sdemeyANS
Copy link
Collaborator

Je pense que le niveau de complétude est le même, j'ai juste défini une slice pour dire les deux types de numéros

moins précise alors car cela ne distingue pas SIREN et SIRET :)

@nriss
Copy link
Member Author

nriss commented Apr 3, 2024

Si, on peut distinguer via le type et via le nombre de caractère dans chacun des numéros :)

@sdemeyANS
Copy link
Collaborator

Si, on peut distinguer via le type et via le nombre de caractère dans chacun des numéros :)

distinction plus faible et plus difficile à valider / implémenter à mon avis :)

@sdemeyANS
Copy link
Collaborator

sdemeyANS commented Apr 3, 2024 •
edited
Loading

fr. core

  • identifier ^slicing.discriminator.type = #pattern
  • identifier ^slicing.discriminator.path = "system"
  • identifier ^slicing.rules = #open
  • identifier ^slicing.description = "Slice based on the identifier.system pattern"

ROR

  • identifier ^slicing.discriminator.type = #value
  • identifier ^slicing.discriminator.path = "type.coding.code"
  • identifier ^slicing.rules = #open

devrait résoudre aussi cette issue #187

@sdemeyANS
Copy link
Collaborator

  • héritage fr-core-healthcare-service
    1er impact : modifier reference vers Location

@sdemeyANS
Copy link
Collaborator

sdemeyANS commented Apr 3, 2024 •
edited
Loading

  • héritage fr-core-healthcare-service
    1er impact : modifier reference vers Location

nécessite héritage fr-core-location => ok

@sdemeyANS
Copy link
Collaborator

nouvelle itération résultat validator : https://github.com/ansforge/IG-fhir-repertoire-offre-ressources-sante/actions/runs/8542708940

reste à voir ./fsh-generated/resources/StructureDefinition-ror-organization.json 05:27:32
[-1, -1] StructureDefinition.differential.element[20]: Error - No match found for Organization.extension:organization-period.value[x].start in the generated snapshot: check that the path and definitions are legal in the differential (including order)
[-1, -1] StructureDefinition.differential.element[21]: Error - No match found for Organization.extension:organization-period.value[x].end in the generated snapshot: check that the path and definitions are legal in the differential (including order)
[-1, -1] StructureDefinition: Error - The profile https://interop.esante.gouv.fr/ig/fhir/ror/StructureDefinition/ror-organization has 2 elements in the differential (id: Organization.extension:organization-period.value[x].start, id: Organization.extension:organization-period.value[x].end) that don't have a matching element in the snapshot: check that the path and definitions are legal in the differential (including order)

@sdemeyANS
Copy link
Collaborator

  1. modification des ref (comme pour les héritages précédents)
  2. un warning sushi : Sushi: warn At least one slice of Practitioner.identifier has a max greater than the overall element max. The max of the following slice(s) has been reduced to match the max of Practitioner.identifier: rpps,adeli (00:04.685 / 00:11.239, 26Mb) et au niveau validator [-1, -1] StructureDefinition.snapshot.element[21]: Information - The slice definition for Practitioner.identifier has a maximum of 1 but the slices add up to a maximum of 3. Check that this is what is intended

@sdemeyANS
Copy link
Collaborator

  1. modification des ref (comme pour les héritages précédents)
  2. un warning sushi : Sushi: warn At least one slice of Practitioner.identifier has a max greater than the overall element max. The max of the following slice(s) has been reduced to match the max of Practitioner.identifier: rpps,adeli (00:04.685 / 00:11.239, 26Mb) et au niveau validator [-1, -1] StructureDefinition.snapshot.element[21]: Information - The slice definition for Practitioner.identifier has a maximum of 1 but the slices add up to a maximum of 3. Check that this is what is intended

=> modification pour prendre en compte la slice héritée sur identifier https://github.com/ansforge/IG-fhir-repertoire-offre-ressources-sante/actions/runs/8552382643 => OK

@sdemeyANS
Copy link
Collaborator

  • héritage fr core practitioner role
    2 profils dans fr core:
  1. https://hl7.fr/ig/fhir/core/StructureDefinition-fr-core-practitioner-role-exercice.html
  2. https://hl7.fr/ig/fhir/core/StructureDefinition-fr-core-practitioner-role-profession.html

A voir lequel correspond le mieux au ROR au niveau fonctionnel ou aucun des 2

@sdemeyANS sdemeyANS linked a pull request Apr 9, 2024 that will close this issue
Sd add new fr core #345
Draft
This was referenced Apr 11, 2024
Open
Open
@sdemeyANS
Copy link
Collaborator

impact aussi #61 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdemeyANS sdemeyANS

Labels
enhancement New feature or request
Projects
None yet
Milestone
tbd
Development

Successfully merging a pull request may close this issue.

Sd add new fr core ansforge/IG-fhir-repertoire-offre-ressources-sante
2 participants
@nriss @sdemeyANS