Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Breaks latex parsing when auto on enabled #259

Closed
Bpklgs opened this issue Jul 21, 2023 · 3 comments · Fixed by asieduernest12/jiffyreader.com#8
Closed

[BUG] Breaks latex parsing when auto on enabled #259

Bpklgs opened this issue Jul 21, 2023 · 3 comments · Fixed by asieduernest12/jiffyreader.com#8
Assignees
Labels
bug Something isn't working

Comments

@Bpklgs
Copy link

Bpklgs commented Jul 21, 2023

Kind of hard to describe but bolding pages before they load breaks parts of them

Reproduce on the extension

  1. Enable auto turn on
  2. Go to https://courseware.cemc.uwaterloo.ca/42/assignments/1139/1
  3. Scroll down a bit and you should see text that shouldn't be there
    image

Expected behavior
go to the website and turn on the extension manually

Desktop (please complete the following information):

  • OS: Windows10
  • Browser: Opera gx
  • Extension version: 1.0.10.1
@Bpklgs Bpklgs added the bug Something isn't working label Jul 21, 2023
@asieduernest12
Copy link
Collaborator

@Bpklgs please include a screen shot if you can to help with the investigation into the issue

@asieduernest12 asieduernest12 self-assigned this Jul 21, 2023
@asieduernest12
Copy link
Collaborator

@asieduernest12 currently you cannot use auto turn-on with this page

the issue:
from the initial review, the page https://courseware.cemc.uwaterloo.ca/42/assignments/1139/1 is running some script to parse latex code and display them as math formula notations in human readable format

the auto turn on code runs immediately after the a page is ready
this is causing the latex code to be jiffied and no longer be valid latex
this means the latex parser is not seeing any valid latex code to transform

a intermetiate fix for this issue is to disable auto turn on for this site and then turn on jiffy manually after the page and latex is ready

an ideal programatic solution is to realease an update that will let you specify a trigger such checking for the presence or absence of some element which then allows auto turn on to engage

this maybe coupled with exponential backoff and retry limit to account for slow or degraded network conditions in order to provide a user experience that is acceptable with out introducing adverse penalties on user interactions

TLDR: disable auto turn on for https://courseware.cemc.uwaterloo.ca/42/assignments/1139/1 by using checking the customize for only this site and then disable auto turn on

@asieduernest12
Copy link
Collaborator

features to consider

  • add support for default auto on triggers as js functions placed in auto - on file
  • make turn on code ternally configurable to accept user defined element exceptions scoped to domains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants