Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite in React or Preact #39

Closed
aviaryan opened this issue Jul 20, 2017 · 11 comments
Closed

Rewrite in React or Preact #39

aviaryan opened this issue Jul 20, 2017 · 11 comments

Comments

@aviaryan
Copy link

aviaryan commented Jul 20, 2017

For a single page app like this, using React or Preact will be the best.
You can also use modern technologies like Webpack for app bundling.

PS - This can be done once we have reached a stable set of features in the current version.

@anshumanv
Copy link
Owner

Yes, will definitely change the technology stack.
Appreciate the suggestion. 👍

@filoxo
Copy link

filoxo commented Oct 1, 2017

I'd love to start rewriting this in React/Preact, at least as a proof-of-concept. Do you have any preference as to which lib (React or Preact)? Also, do you have a preference as to a build system (create-react-app, Next.js, nwb, etc.)?

@anshumanv
Copy link
Owner

Thanks @filoxo for contributing here !
I'm a bit familiar with react so go with it.
Also no personal preferences for a build system, use whichever is suitable to you 👍

@anshumanv
Copy link
Owner

Do you have any preferences for this @aviaryan ?

@aviaryan
Copy link
Author

aviaryan commented Oct 2, 2017

@anshumanv React from my side. Though VueJS is interesting too.

@anshumanv
Copy link
Owner

Yeah VueJS is popular among developers now a days @aviaryan .
Let's go for react then @filoxo , you can get started when you like 😄

@filoxo
Copy link

filoxo commented Oct 2, 2017

While I haven't done anything in Vue yet, I have been wanting to try it out. It also as a pretty prolific community around it, has similar build tools (vue-cli, nuxt.js), has similar state management libs (vuex), and great documentation. I don't think this would be a bad choice.
Ultimately you'll be the ones to maintain it so whatever you decide I'm totally on board with. I'll go ahead with React for now. I think the app is small enough that it wouldn't be hard to pivot at a later point.

@anshumanv
Copy link
Owner

anshumanv commented Oct 2, 2017

Thanks so much @filoxo ! 😄
Perhaps what are your views on carrying this out on a separate repo (to keep the workplace clean and isolated) ?

@filoxo
Copy link

filoxo commented Oct 2, 2017

Sure, another repo would be fine. I had already created a separate branch on my fork, but whatever works best for you.

@anshumanv
Copy link
Owner

Have added you in the repo @filoxo , please check invite.
Let's follow up there. 😄

@anshumanv
Copy link
Owner

Made with 💟 by @filoxo here.
We will soon use that repo to serve ongaku. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants