Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elb_target_group doesn't change health_check_path on existing target group #15

Closed
briantist opened this issue Mar 25, 2020 · 2 comments
Closed

Comments

@briantist
Copy link
Contributor

briantist commented Mar 25, 2020

SUMMARY

The health_check_path option is ignored on an existing target group. Changing it gives a status of ok and the setting is not changed.

I suspect this affects more health check options but haven't tried them.

Turns out this is a duplicate of ansible/ansible#50024

You have to supply health_check_protocol in order for health_check_path to be considered.

But the documentation still doesn't reflect that.

And really, the purpose of the check is to ignore params that only apply to http and https protocols. The check should:

  1. Throw an error (at least a warning?) when a the options that don't apply to your protocol are supplied
  2. Assume the health_check_protocol is the same as protocol if the former is not supplied, since that's what happens in reality

So I think this should remain open.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

elb_target_group

ANSIBLE VERSION

2.9

CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE
  • Create target group
  • Change the health_check_path option to something else
  • Run again
EXPECTED RESULTS
  • changed status with updated value
ACTUAL RESULTS
  • ok status with no change
@wimnat
Copy link
Contributor

wimnat commented Apr 7, 2020

This and the other issues should reside in https://github.com/ansible-collections/community.aws not here as they are community supported modules.

@briantist
Copy link
Contributor Author

@wimnat thanks I thought I had moved the rest but it turns out I only did one of them.

I think #8 should stay here though, as the problem resides in the module util backing both modules, not in the modules themselves.


This issue closed in favor of ansible-collections/community.aws#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants