Add in check_mode to be supported for eos_route_maps #480

jakegroves · 2023-11-08T21:56:51Z

SUMMARY

Fixes the ability to see the --check mode, so can check changes before running.

ISSUE TYPE

Bugfix Pull Request (Fixes eos_route_maps module does not have check mode #481)

COMPONENT NAME

eos_route_maps

ADDITIONAL INFORMATION

Example playbook

- name: Replace provided route map configuration
  arista.eos.eos_route_maps:
    state: replaced
    config: "{{ eos_route_maps.config }}"
  register: replace_route_map_command

- name: Display route map changes
  debug:
    var: replace_route_map_command.commands
  when: replace_route_map_command is changed

Before changes:

PLAY [router] ***************************************************************************************************************************************************************************************************************************************

TASK [route_map : Replace provided route map configuration] *****************************************************************************************************************************************************************************************
skipping: [router1]

TASK [route_map : Display route map changes] ********************************************************************************************************************************************************************************************************
skipping: [router1]

After changes:

PLAY [router] ***************************************************************************************************************************************************************************************************************************************

TASK [route_map : Replace provided route map configuration] *****************************************************************************************************************************************************************************************
changed: [router1]

TASK [route_map : Display route map changes] ********************************************************************************************************************************************************************************************************
ok: [router1] => {
    "replace_route_map_command.commands": [
        "route-map Example-RM permit 10",
        "set local-preference 110"
    ]
}

codecov · 2023-11-08T21:59:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef5facc) 82.76% compared to head (71f52de) 82.75%.

❗ Current head 71f52de differs from pull request most recent head a28b730. Consider uploading reports for the commit a28b730 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   82.76%   82.75%   -0.01%     
==========================================
  Files         153      153              
  Lines       11967    11967              
==========================================
- Hits         9904     9903       -1     
- Misses       2063     2064       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

softwarefactory-project-zuul · 2023-11-08T22:56:04Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/60ac826e876644a6a229d253716d0a3b

softwarefactory-project-zuul · 2023-11-29T12:11:46Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a05893d7b3434d3dadf0ee363a4745a7

for more information, see https://pre-commit.ci

github-actions · 2023-12-06T22:28:26Z

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

softwarefactory-project-zuul · 2023-12-06T23:31:24Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5861fece5c4e45d8a7692d891acf8695

jakegroves temporarily deployed to ack November 8, 2023 21:56 — with GitHub Actions Inactive

pre-commit-ci bot temporarily deployed to ack November 8, 2023 21:57 Inactive

jakegroves mentioned this pull request Nov 8, 2023

eos_route_maps module does not have check mode #481

Open

NilashishC approved these changes Nov 17, 2023

View reviewed changes

rohitthakur2590 temporarily deployed to ack November 29, 2023 11:06 — with GitHub Actions Inactive

jagexjake and others added 2 commits December 6, 2023 22:28

Add in check_mode to be supported for eos_route_maps

ad08efc

[pre-commit.ci] auto fixes from pre-commit.com hooks

a28b730

for more information, see https://pre-commit.ci

jakegroves force-pushed the route_map_check_mode branch from f4b6416 to a28b730 Compare December 6, 2023 22:28

jakegroves had a problem deploying to ack December 6, 2023 22:28 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add in check_mode to be supported for eos_route_maps #480

Add in check_mode to be supported for eos_route_maps #480

jakegroves commented Nov 8, 2023 •

edited

codecov bot commented Nov 8, 2023 •

edited

softwarefactory-project-zuul bot commented Nov 8, 2023

softwarefactory-project-zuul bot commented Nov 29, 2023

github-actions bot commented Dec 6, 2023

softwarefactory-project-zuul bot commented Dec 6, 2023

Add in check_mode to be supported for eos_route_maps #480

Are you sure you want to change the base?

Add in check_mode to be supported for eos_route_maps #480

Conversation

jakegroves commented Nov 8, 2023 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

codecov bot commented Nov 8, 2023 • edited

Codecov Report

softwarefactory-project-zuul bot commented Nov 8, 2023

softwarefactory-project-zuul bot commented Nov 29, 2023

github-actions bot commented Dec 6, 2023

softwarefactory-project-zuul bot commented Dec 6, 2023

jakegroves commented Nov 8, 2023 •

edited

codecov bot commented Nov 8, 2023 •

edited