Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vrf_global resource module #1055

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add vrf_global resource module #1055

wants to merge 20 commits into from

Conversation

Ruchip16
Copy link
Contributor

@Ruchip16 Ruchip16 commented Apr 16, 2024 •
edited

SUMMARY

This PR adds support for ios.vrf_global resource module

Here is the model design for the vrf_global module

ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

cisco.ios.ios_vrf_global

MILESTONES
  • Parsing entire argspec ( which covers gathered and parsed state )
  • Merged and Rendered state working
  • Replaced state working
  • Overridden state working
  • Deleted and purged state
  • Unit tests & Integration tests

@Ruchip16 Ruchip16 added the feature This issue/PR relates to a feature request. label Apr 16, 2024
@Ruchip16 Ruchip16 marked this pull request as draft April 16, 2024 12:19
@KB-perByte KB-perByte marked this pull request as ready for review April 17, 2024 09:31
@KB-perByte KB-perByte closed this Apr 17, 2024
@KB-perByte KB-perByte reopened this Apr 17, 2024
@rohitthakur2590 rohitthakur2590 self-requested a review April 17, 2024 09:54
rohitthakur2590
rohitthakur2590 requested changes Apr 18, 2024
View reviewed changes
plugins/modules/ios_vrf_global.py Outdated Show resolved Hide resolved
plugins/modules/ios_vrf_global.py Outdated Show resolved Hide resolved
plugins/modules/ios_vrf_global.py Show resolved Hide resolved
plugins/modules/ios_vrf_global.py Show resolved Hide resolved
plugins/modules/ios_vrf_global.py Show resolved Hide resolved
@Ruchip16 Ruchip16 marked this pull request as draft April 19, 2024 14:41
@Ruchip16 Ruchip16 marked this pull request as ready for review April 22, 2024 06:47
rohitthakur2590
rohitthakur2590 requested changes Apr 22, 2024
View reviewed changes
plugins/action/vrf_global.py Outdated Show resolved Hide resolved
plugins/modules/ios_vrf_global.py Outdated Show resolved Hide resolved
@Ruchip16 Ruchip16 requested a review from NilashishC May 13, 2024 16:07
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (c9841b5) to head (38ee04f).
Report is 8 commits behind head on main.

❗ Current head 38ee04f differs from pull request most recent head 6d3d8e2

Please upload reports for the commit 6d3d8e2 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   86.90%   87.06%   +0.16%     
==========================================
  Files         193      199       +6     
  Lines       11904    12098     +194     
==========================================
+ Hits        10345    10533     +188     
- Misses       1559     1565       +6

see 14 files with indirect coverage changes

rohitthakur2590
rohitthakur2590 approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@rohitthakur2590 rohitthakur2590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitthakur2590 rohitthakur2590 rohitthakur2590 approved these changes

@KB-perByte KB-perByte Awaiting requested review from KB-perByte

@roverflow roverflow Awaiting requested review from roverflow

@NilashishC NilashishC Awaiting requested review from NilashishC

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cisco.ios.ios_vrf fail when sending status absent on missing VRF Add parsed and rendered states to ios_vrf
3 participants
@Ruchip16 @KB-perByte @rohitthakur2590