Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate sanity test ignores by fixing the actual problems #13

Closed
geerlingguy opened this issue Aug 5, 2020 · 2 comments
Closed

Mitigate sanity test ignores by fixing the actual problems #13

geerlingguy opened this issue Aug 5, 2020 · 2 comments
Assignees
@mamercad
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@geerlingguy
Copy link
Collaborator

SUMMARY

Currently the sanity tests for this module have a number of rules ignored (16 total) in https://github.com/ansible-collections/community.digitalocean/blob/main/tests/sanity/ignore-2.11.txt

It would be nice if we could get that down to zero—or just a couple.

ISSUE TYPE
  • Bug Report
COMPONENT NAME

Tests

ANSIBLE VERSION

N/A

CONFIGURATION

N/A

OS / ENVIRONMENT

N/A
@gundalow gundalow added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 2, 2021
@mamercad mamercad self-assigned this Apr 10, 2021
@mamercad
Copy link
Collaborator

Agree, working on it.

@mamercad mamercad mentioned this issue Apr 10, 2021
Merged
@gundalow
Copy link
Contributor

Cleaned up by #54

Now we only have ignore-2.9.txt https://github.com/ansible-collections/community.digitalocean/tree/main/tests/sanity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mamercad mamercad

Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@geerlingguy @gundalow @mamercad