Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource_id field to redfish_info #8331

Open
1 task done
AvinashJalumuru opened this issue May 8, 2024 · 5 comments
Open
1 task done

Add resource_id field to redfish_info #8331

AvinashJalumuru opened this issue May 8, 2024 · 5 comments
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)

Comments

@AvinashJalumuru
Copy link

Summary

resource_id parameter is accepted in redfish_command and redfish_config which is very much useful to pass the ID of the System, Manager or Chassis. This feature is missing in redfish_info.

Adding resource_id field in community.general.redfish_info would benefit all users (along with me) using redfish to manage/configure multi-systems.

Issue Type

Feature Idea

Component Name

redfish_info

Additional Information

  - name: Get default system inventory and user information of resource 437XR1138R2
    community.general.redfish_info:
      category: Systems,Accounts
      baseuri: "{{ baseuri }}"
      username: "{{ username }}"
      password: "{{ password }}"
      resource_id: 437XR1138R2

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link
Collaborator

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module plugins plugin (any type) labels May 8, 2024
@mraineri
Copy link
Contributor

The existing utilities in redfish_info (with some exceptions I'll point out later) are returning all instances regardless of the number of chassis or system instances. So, if you invoke "GetSystemInventory", it calls "get_multi_system_inventory" to collect information from each member of the systems collection. Likewise, "GetCpuInventory" will call "get_multi_cpu_inventory", which collects the CPU inventory from each system in the systems collection. With this behavior in place today, is there a need to call out specific resources?

Specifically for the GetLogs and GetNetworkProtocols commands under Manager, these two do not handle multi-manager designs. There is an open issue (#6764) and pull request (#8178) for this.

@AvinashJalumuru
Copy link
Author

Thanks @mraineri for sharing the details and background.

Just a thought, if there are many systems/managers, would it not be nicer to have a resource_id flag to fetch details of single instance instead of querying the list of systems or managers and using ansible task to filter the needed resource.

@mraineri
Copy link
Contributor

I had a chat with a few others, and we're thinking it's reasonable to add this capability for all redfish_info commands. Will need to plan this change out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module module plugins plugin (any type)
Projects
None yet
Development

No branches or pull requests

3 participants