Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_iam_login method needs tests #118

Closed
briantist opened this issue Aug 1, 2021 · 1 comment · Fixed by #193
Closed

aws_iam_login method needs tests #118

briantist opened this issue Aug 1, 2021 · 1 comment · Fixed by #193
Assignees
Labels
tests Adds or modifies tests

Comments

@briantist
Copy link
Collaborator

SUMMARY

There's some difficulty to this one, as we don't have any AWS IAM stuff to set up a backend against.

Unit tests can be added for a lot of it though, especially the validation/option processing.

For some level of integration, I am considering introducing MMock, and trying to mock the Vault API end of things so that we never actually have to contact AWS.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
@briantist briantist self-assigned this Aug 1, 2021
@briantist briantist added the tests Adds or modifies tests label Aug 1, 2021
@briantist briantist moved this from To do to In progress in CI and Testing Improvements Oct 20, 2021
@briantist
Copy link
Collaborator Author

Basic units are added in #161 , those will be fleshed out more soon, hopefully with the addition of some integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Adds or modifies tests
Development

Successfully merging a pull request may close this issue.

1 participant