vmware_guest Create VM with Windows Template without parameter guest_id

[SilentT19]

SUMMARY

When create VM with Windows template with customisation and without guest_id, the module send linux customisation

ISSUE TYPE

• Bug Report

COMPONENT NAME

vmware_guest

ANSIBLE VERSION

2.10.7

CONFIGURATION

Ubuntu 20.04 , pyvmomi 7.0.1
vCenter Server 6.5u3n 17590285 

OS / ENVIRONMENT

OS : Windows

STEPS TO REPRODUCE

Simply use vmware_guest with windows template with customization

 name:  Deploy VM
  community.vmware.vmware_guest:
....
    template: '{{ Windows_Template }}'
...

EXPECTED RESULTS

The VM was created with customisation and without error in vcenter

ACTUAL RESULTS

-->       customization = (vim.vm.customization.Specification) {
-->          options = (vim.vm.customization.Options) null,
-->          identity = (vim.vm.customization.LinuxPrep) {

[ansibullbot]

Files identified in the description:

• [plugins/modules/vmware_guest.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/vmware_guest.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Akasurde @Tomorrow9 @goneri @lparkes @nerzhul @pdellaert @pgbidkar @warthog9
click here for bot help

[SilentT19]

community.vmware/plugins/modules/vmware_guest.py

Line 2303 in f913056

if 'win' in guest_id:

if win in guest_id but guest_id was not required if use template

https://docs.ansible.com/ansible/2.10/collections/community/vmware/vmware_guest_module.html#parameter-guest_id

"This field is required when creating a virtual machine, not required when creating from the template."

community.vmware/plugins/modules/vmware_guest.py

Line 2299 in f913056

guest_id = vm_obj.summary.config.guestId

vCenter inventory output the guestid ?

[SilentT19]

Perhaps this problem #75 is related too

[Akasurde]

@SilentT19 Thanks for reporting this issue. GuestID information is gathered using VMware Tools installed inside the VM. If VMware tools fail to detect or wrongly report the guest id then the module would misbehave. I am afraid that there is no other way to detect guest id.

Please try updating vmware tools in Guest OS.

[SilentT19]

I think that when we prepare and use a template, the guestOS is registered in the configuration of the template and it is cloned with the VM, Liked this

I think that we should use this parameter instead of that of the tools.