Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for missing commits vs devel #166

Closed
gundalow opened this issue Mar 9, 2020 · 5 comments
Closed

Check for missing commits vs devel #166

gundalow opened this issue Mar 9, 2020 · 5 comments

Comments

@gundalow
Copy link
Collaborator

gundalow commented Mar 9, 2020

SUMMARY

The "Big Migration" has now taken place.

As this collection already exists, we need to carefully check to see if any further commits went into devel since this repo was created.

Please check the contents of https://github.com/ansible-collection-migration/google.cloud against this repo

ISSUE TYPE
  • Bug Report
@gundalow
Copy link
Collaborator Author

gundalow commented Mar 9, 2020

Clarification:

  • Please do a per-file level diff against every file in the ansible-collection-migration repo and this one
  • Pay care to files added and removed.
  • During the last two weeks there have been lots of fixes, especially around and tests, dependencies, and new collection features e.g. meta/action_groups.yml

@gundalow
Copy link
Collaborator Author

#167 could be an example of such a missing change.

@rambleraptor
Copy link
Contributor

I've gone through the diffs and everything seems to be in order (there are changes that exist in the collection, but never upstreamed to core).

Could you elaborate on some of the new collection features (like meta/action_groups.yml) or point me to some documentation for them?

@gundalow
Copy link
Collaborator Author

No proper docs yet, though ansible/ansible#68383 and ansible/ansible#67291 may help.

@toumorokoshi
Copy link
Collaborator

I'll close this as I believe it's outdated, but feel free to re-open if there's anything further to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants