k8s_scale - handle scaling StatefulSets with 'updateStrategy=OnDelete' #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravesm
reviewed
Feb 3, 2023
plugins/module_utils/k8s/waiter.py
Outdated
| @@ -66,7 +66,7 @@ def statefulset_ready(statefulset: ResourceInstance) -> bool: | |||
| ready_replicas = statefulset.status.readyReplicas or 0 | |||
| return bool( | |||
| statefulset.status | |||
| and statefulset.spec.updateStrategy.type == "RollingUpdate" | |||
| and statefulset.spec.updateStrategy.type in ["RollingUpdate", "OnDelete"] | |||
There was a problem hiding this comment.
This one is a bit tricky. The problem with StatefulSets that use OnDelete is that the currentRevision and updateRevision may not match, since pods aren't replaced until they are manually deleted. In some cases, updatedReplicas may also not match the spec's replicas. You can see this by creating a StatefulSet using the OnDelete update strategy and more than one replica. Then, in a separate task, modify the container spec. Now, scale it down to 1 replica.
I think what we need here is two sets of conditions, one for RollingUpdate and one for OnDelete. The block for OnDelete should not check the revision or the updated replicas. So something like:
if statefulset.spec.updateStrategy.type == "OnDelete":
return bool(...) # modified condition checks
return bool(...) # current condition checks
mandar242
force-pushed
the
k8s_core_503
branch
from
0aa3f26
to
26de935
Compare
gravesm
approved these changes
Feb 6, 2023
abikouo
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Likely Fixes #503
Handle scaling StatefulSets with 'updateStrategy=OnDelete'
ISSUE TYPE
COMPONENT NAME
k8s_scale
ADDITIONAL INFORMATION