Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microsoft.ad.membership add reboot timeout option #78

Open
markatdxb opened this issue Oct 24, 2023 · 2 comments
Open

microsoft.ad.membership add reboot timeout option #78

markatdxb opened this issue Oct 24, 2023 · 2 comments

Comments

@markatdxb
Copy link

SUMMARY

Would be great to add option in this module to set the reboot timeout. Currently when joining physical servers to domain im getting module errors due to reboot timeout
Its not a big deal as i can work around it by not using this option and instead using the standard reboot module - just an idea

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

microsoft.ad.membership

ADDITIONAL INFORMATION

"msg": "Timed out waiting for last boot time check (timeout=600)",

{
    "changed": true,
    "msg": "Failed to reboot after module returned reboot_required, see reboot_result and module_result for more details",
    "reboot_result": {
        "changed": true,
        "elapsed": 605,
        "failed": true,
        "unreachable": false,
        "rebooted": true,
        "msg": "Timed out waiting for last boot time check (timeout=600)",
        
    },
    "module_result": {
        "changed": true,
        "reboot_required": true
    },
    "invocation": {
        "module_args": {
            "reboot": true,
            "dns_domain_name": "domain",
            "domain_admin_user": "domain_admin",
            "offline_join_blob": null,
            "domain_admin_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "workgroup_name": null,
            "state": "domain",
            "hostname": "server1",
            "domain_ou_path": null
        }
    },
    "_ansible_no_log": null,
    "_ansible_delegated_vars": {
        "ansible_host": "10.10.10.10",
        "ansible_port": 5986,
        "ansible_user": "{{ username }}",
        "ansible_connection": "winrm"
    }
}
@jborean93
Copy link
Collaborator

Are you finding that it's just taking longer than 10 minutes for the reboot to return? I would be reluctant to add more options for this in favour of an explicit win_reboot call when needed as the typical use case should definitely return before 10 minutes. Are you consistently seeing it take a particular amount of time, do you know why it might be taking so long?

@markatdxb
Copy link
Author

In general 10 minutes is more than enough for standard VMs. I have seen these timeouts when joining physical servers to domain where bios load, lifecycle controller checks etc do take significant time.
But also as mentioned its not a big deal as i can workaround it with win_reboot module where i can actually set reboot timeout to higher number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants