-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmware_content_deploy_ovf_template - create VMs from OVF templates #114
Conversation
…VF templates (113)
vmware_content_deploy_ovf_template.py:115:1: E302 expected 2 blank lines, found 1 vmware_content_deploy_ovf_template.py:234:1: E305 expected 2 blank lines after class or function definition,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @ultral, what do we need to test this module in the CI? Do you have some OVF example that are light enough? |
Hi @goneri
Nope, my images are built for dev env by packer, so they are big enough. However for test purpose we can use the smallest image without OS |
We use this image to start our test VMs: virt-lightning.org/fedora-open-vm-tools-livecd.iso . I'm not familiar with the OVF template, could we generate a template that uses use it? |
so, please correct me if I'm wrong, we should create an OVF template which boots from the ISO. how do you an template of things like that usually? is automated process and we need a commit? or people upload it somewhere? |
Thanks. Do you know if we can we automate the OVF creation process? I don't mind having a OVF somewhere that we maintain ourselves, but I would prefer to have a reproducible way to generate it. |
sure, In my env I use jenkins + packer for creating OVF templates. unfortunately, I can not show the real config, however there is the gist https://github.com/ultral/vmware_centos_packer_contentlibrary_ovf
if you share info how to your build infrastructure work and how we can create OVF for it i will think how to create the test suites for that module. |
Thanks @ultral! |
Thank you @ultral for your contribution :-) |
…nsible-collections#114) vmware_content_deploy_ovf_template - create VMs from OVF templates Reviewed-by: https://github.com/apps/ansible-zuul
…nsible-collections#114) vmware_content_deploy_ovf_template - create VMs from OVF templates Reviewed-by: https://github.com/apps/ansible-zuul
SUMMARY
vmware_content_deploy_template doesn't support creating VM from OVF templates "Fixes #113"
ISSUE TYPE
COMPONENT NAME
vmware_content_deploy_ovf_template