Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_content_deploy_ovf_template - create VMs from OVF templates #114

Merged
merged 6 commits into from
Apr 15, 2020

Conversation

ultral
Copy link
Contributor

@ultral ultral commented Apr 13, 2020

SUMMARY

vmware_content_deploy_template doesn't support creating VM from OVF templates "Fixes #113"

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_content_deploy_ovf_template

vmware_content_deploy_ovf_template.py:115:1: E302 expected 2 blank lines, found 1
vmware_content_deploy_ovf_template.py:234:1: E305 expected 2 blank lines after class or function definition,
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

plugins/modules/vmware_content_deploy_ovf_template.py Outdated Show resolved Hide resolved
plugins/modules/vmware_content_deploy_ovf_template.py Outdated Show resolved Hide resolved
ultral and others added 2 commits April 14, 2020 07:38
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde requested a review from goneri April 14, 2020 05:03
@goneri
Copy link
Member

goneri commented Apr 14, 2020

Hi @ultral, what do we need to test this module in the CI? Do you have some OVF example that are light enough?

@ultral
Copy link
Contributor Author

ultral commented Apr 14, 2020

Hi @goneri

what do we need to test this module in the CI?

  • vmware vsphere
  • content library
  • OVF template in the content library
  • possibility to import

Do you have some OVF example that are light enough?

Nope, my images are built for dev env by packer, so they are big enough. However for test purpose we can use the smallest image without OS

@goneri
Copy link
Member

goneri commented Apr 14, 2020

We use this image to start our test VMs: virt-lightning.org/fedora-open-vm-tools-livecd.iso . I'm not familiar with the OVF template, could we generate a template that uses use it?

@ultral
Copy link
Contributor Author

ultral commented Apr 14, 2020

We use this image to start our test VMs: virt-lightning.org/fedora-open-vm-tools-livecd.iso . I'm not familiar with the OVF template, could we generate a template that uses use it?

so, please correct me if I'm wrong, we should create an OVF template which boots from the ISO. how do you an template of things like that usually? is automated process and we need a commit? or people upload it somewhere?

@goneri
Copy link
Member

goneri commented Apr 14, 2020

We use this image to start our test VMs: virt-lightning.org/fedora-open-vm-tools-livecd.iso . I'm not familiar with the OVF template, could we generate a template that uses use it?

so, please correct me if I'm wrong, we should create an OVF template which boots from the ISO. how do you an template of things like that usually? is automated process and we need a commit? or people upload it somewhere?

Thanks. Do you know if we can we automate the OVF creation process? I don't mind having a OVF somewhere that we maintain ourselves, but I would prefer to have a reproducible way to generate it.

@ultral
Copy link
Contributor Author

ultral commented Apr 15, 2020

We use this image to start our test VMs: virt-lightning.org/fedora-open-vm-tools-livecd.iso . I'm not familiar with the OVF template, could we generate a template that uses use it?

so, please correct me if I'm wrong, we should create an OVF template which boots from the ISO. how do you an template of things like that usually? is automated process and we need a commit? or people upload it somewhere?

Thanks. Do you know if we can we automate the OVF creation process? I don't mind having a OVF somewhere that we maintain ourselves, but I would prefer to have a reproducible way to generate it.

sure, In my env I use jenkins + packer for creating OVF templates. unfortunately, I can not show the real config, however there is the gist https://github.com/ultral/vmware_centos_packer_contentlibrary_ovf

  1. build the VM via packer
  2. create OVF template from the VM

if you share info how to your build infrastructure work and how we can create OVF for it i will think how to create the test suites for that module.

@goneri
Copy link
Member

goneri commented Apr 15, 2020

We use this image to start our test VMs: virt-lightning.org/fedora-open-vm-tools-livecd.iso . I'm not familiar with the OVF template, could we generate a template that uses use it?

so, please correct me if I'm wrong, we should create an OVF template which boots from the ISO. how do you an template of things like that usually? is automated process and we need a commit? or people upload it somewhere?

Thanks. Do you know if we can we automate the OVF creation process? I don't mind having a OVF somewhere that we maintain ourselves, but I would prefer to have a reproducible way to generate it.

sure, In my env I use jenkins + packer for creating OVF templates. unfortunately, I can show the real config, however there is the gist https://github.com/ultral/vmware_centos_packer_contentlibrary_ovf

1. build the VM via packer

2. create OVF template from the VM

if you share info how to your build infrastructure work and how we can create OVF for it i will think how to create the test suites for that module.

Thanks @ultral!

@goneri goneri added the gate label Apr 15, 2020
@ansible-zuul ansible-zuul bot merged commit 6d4ea1e into ansible-collections:master Apr 15, 2020
@goneri
Copy link
Member

goneri commented Apr 15, 2020

Thank you @ultral for your contribution :-)

misacek007 pushed a commit to misacek007/vmware that referenced this pull request Jun 5, 2020
phsmith pushed a commit to phsmith/vmware that referenced this pull request Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmware_content_deploy_template doesn't support creating VM from OVF templates
3 participants