Add tests for import_tasks and include_tasks target lookup
#1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
europ
force-pushed
the
test_for_import_tasks
branch
from
1343251
to
a4ee5ea
Compare
webknjaz
reviewed
Mar 8, 2021
webknjaz
reviewed
Mar 8, 2021
webknjaz
reviewed
Mar 8, 2021
webknjaz
reviewed
Mar 8, 2021
Please adjust the explanation and the title to mention what this test is about. |
webknjaz
reviewed
Mar 8, 2021
webknjaz
reviewed
Mar 8, 2021
webknjaz
reviewed
Mar 8, 2021
webknjaz
changed the title
import_tasks and include_tasks target lookup
europ
force-pushed
the
test_for_import_tasks
branch
3 times, most recently
from
1a2da16
to
7024149
Compare
webknjaz
reviewed
Mar 9, 2021
webknjaz
reviewed
Mar 9, 2021
webknjaz
reviewed
Mar 9, 2021
webknjaz
reviewed
Mar 9, 2021
webknjaz
reviewed
Mar 9, 2021
europ
force-pushed
the
test_for_import_tasks
branch
from
7024149
to
3f00d00
Compare
webknjaz
reviewed
Mar 9, 2021
webknjaz
reviewed
Mar 9, 2021
Regression tests for issue number 1446
europ
force-pushed
the
test_for_import_tasks
branch
from
3f00d00
to
6cff3f9
Compare
ssbarnea
approved these changes
Mar 9, 2021
ssbarnea
reviewed
Mar 9, 2021
| @pytest.mark.parametrize( | ||
| 'ansible_project_layout', | ||
| ( | ||
| pytest.param(LAYOUT_IMPORTS, id='using only import_tasks'), |
There was a problem hiding this comment.
Usually I prefer test ids that do not have spaces or special chars, so I can use them with -k without trouble but I will likely fix it next time we need to touch the test, hopefully soon for removal of xfail.
There was a problem hiding this comment.
FWIW spaced ids work with -k just fine. But I prefer concrete specifiers like tox -- 'test/TestFilePathEvaluation.py::test_file_path_evaluation[using only include_tasks]'
This was referenced Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible-lint incorrectly evaluates the file path when
import_tasksorinclude_tasksis used because of a bug that was reported in the following issue #1446.import_tasksinclude_tasks