Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow import_playbook from collections #2018

Merged
merged 1 commit into from Mar 18, 2022
Merged

Allow import_playbook from collections #2018

merged 1 commit into from Mar 18, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 18, 2022 •
edited

Fixes: #1879

@ssbarnea ssbarnea added the bug label Mar 18, 2022
@ssbarnea ssbarnea marked this pull request as ready for review March 18, 2022 09:14
@ssbarnea ssbarnea requested a review from a team as a code owner March 18, 2022 09:14
@ssbarnea ssbarnea requested review from relrod, webknjaz, priyamsahoo, cognifloyd, cidrblock, a team and ganeshrn and removed request for a team March 18, 2022 09:14
ganeshrn
ganeshrn approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test case for this scenario?

@ssbarnea
Copy link
Member Author

Can you add test case for this scenario?

I already did. That modified example is part of a test, like all of them. Most bugfixes do not require adding new tests, just modifying the fixtures.

@ssbarnea ssbarnea merged commit 30b2997 into ansible:main Mar 18, 2022
@ssbarnea ssbarnea deleted the fix/import-collection branch March 18, 2022 09:45
@ssbarnea ssbarnea mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@relrod relrod Awaiting requested review from relrod relrod was automatically assigned from ansible-community/devtools

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

@cognifloyd cognifloyd Awaiting requested review from cognifloyd

@cidrblock cidrblock Awaiting requested review from cidrblock

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

importing playbooks using FQCN doesn't work
2 participants
@ssbarnea @ganeshrn