deprecated-local-action: refactor to use matchtask() #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
Signed-off-by: nishipy <goodisonev4@gmail.com>
nishipy
changed the title
Signed-off-by: nishipy <goodisonev4@gmail.com>
nishipy
force-pushed
the
refactor-deprecated-local-action
branch
from
29d7438
to
0f97a0e
Compare
Signed-off-by: nishipy <goodisonev4@gmail.com>
cognifloyd
reviewed
Jul 15, 2022
src/ansiblelint/utils.py
Outdated
|
|
||
| # check if module invocated with old style | ||
| old_style_keys = ("local_action",) | ||
| result = _extract_old_style_keys_from_task(result, sanitized_task, old_style_keys) |
There was a problem hiding this comment.
This is kind of cool.
But, we might not need to change any of the utils because of another newish feature: needs_raw_task.
If the rule class has needs_raw_task = True as a class level variable, then matchtask gets passed the raw/unparsed task in task["__raw_task__"].
Would that work here?
There was a problem hiding this comment.
Thank you! Using task["__raw_task__"] looks smart and enough for us. Let me fix that.
| SUCCESS_TASK = """ | ||
| - name: task example | ||
| boto3_facts: | ||
| delegate_to: localhost # local_action |
Signed-off-by: nishipy <goodisonev4@gmail.com>
cognifloyd
approved these changes
Jul 19, 2022
ssbarnea
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #2105.
This PR fixes the following points for
deprecated-local-action: