New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for rule profiles #2245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
feat/profiles
branch
3 times, most recently
from
July 21, 2022 15:12
f3b1c10
to
85e767d
Compare
ssbarnea
changed the title
[WIP]: Add support for rule profiles
Add experimental support for rule profiles
Jul 21, 2022
ssbarnea
changed the title
Add experimental support for rule profiles
Add initial support for rule profiles
Jul 26, 2022
cidrblock
approved these changes
Jul 27, 2022
cognifloyd
reviewed
Jul 27, 2022
ganeshrn
reviewed
Jul 27, 2022
ganeshrn
reviewed
Jul 27, 2022
ganeshrn
reviewed
Jul 27, 2022
ganeshrn
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge from my side after the minor comments are fixed
priyamsahoo
approved these changes
Jul 28, 2022
Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is advertised as experimental because it includes listing of multiple planned rules which we will implement over the following months. They are documented here in order to set expectations about at which profile level users should expect to see them.
This feature does not change the behavior of ansible-lint unless user is adding
--profile
argument.Fixes: #2109