Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for rule profiles #2245

Merged
merged 4 commits into from Jul 28, 2022
Merged

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jul 21, 2022

This change is advertised as experimental because it includes listing of multiple planned rules which we will implement over the following months. They are documented here in order to set expectations about at which profile level users should expect to see them.

This feature does not change the behavior of ansible-lint unless user is adding --profile argument.

Fixes: #2109

@ssbarnea ssbarnea requested a review from cidrblock July 21, 2022 12:18
@ssbarnea ssbarnea force-pushed the feat/profiles branch 3 times, most recently from f3b1c10 to 85e767d Compare July 21, 2022 15:12
@ssbarnea ssbarnea changed the title [WIP]: Add support for rule profiles Add experimental support for rule profiles Jul 21, 2022
@ssbarnea ssbarnea marked this pull request as ready for review July 21, 2022 17:34
@ssbarnea ssbarnea requested review from a team as code owners July 21, 2022 17:34
@ssbarnea ssbarnea changed the title Add experimental support for rule profiles Add initial support for rule profiles Jul 26, 2022
docs/profiles.md Outdated Show resolved Hide resolved
src/ansiblelint/cli.py Show resolved Hide resolved
src/ansiblelint/__main__.py Show resolved Hide resolved
@ssbarnea ssbarnea requested a review from cognifloyd July 27, 2022 16:57
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge from my side after the minor comments are fixed

@ssbarnea ssbarnea merged commit 04f808a into ansible:main Jul 28, 2022
@ssbarnea ssbarnea deleted the feat/profiles branch July 28, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating profiles and associate rules with AAP profile
5 participants