Refactor no-loop-var-prefix rule #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oraNod
commented
Sep 20, 2022
•
oraNod
commented
- rename rule to loop-var-prefix and keep alias for old name
- make rule produce more detailed messages
- add documentation to the rule
|
@ssbarnea Hi. Not sure about this one at all and am kind of reaching. I couldn't trigger this rule and am unsure about the description. I think I'm also missing some nuances about roles in the docs. If you could please take a look and let me know where I'm going wrong I'd appreciate it. Cheers. |
ssbarnea
force-pushed
the
rule-docs-no-loop-var
branch
from
da94567
to
8e493bb
Compare
ssbarnea
changed the title
for more information, see https://pre-commit.ci
- rename rule to loop-var-prefix and keep alias for old name - make rule produce more detailed messages - add documentation to the rule
ssbarnea
approved these changes
Sep 23, 2022
ssbarnea
force-pushed
the
rule-docs-no-loop-var
branch
from
eb54da2
to
ddb4f9a
Compare
davedittrich
pushed a commit
to davedittrich/ansible-lint
that referenced
this pull request
Sep 27, 2022
* docs lint rule no-loop-var * chore: auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Refactor no-loop-var-prefix - rename rule to loop-var-prefix and keep alias for old name - make rule produce more detailed messages - add documentation to the rule Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.