Test get_version_warning #2632
Merged
Test get_version_warning #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is testing that get_version_warning(): - returns "" if current version is latest one - returns a pre-release information if using pre-release - returns a new release information and extra installation information. (note: this test doesn't check that guess_install_method() is working correctly) I had to use pytest-mock to ensure that all test parameters are correctly set. The test should not rely on current version (since it's likely v1.2.3dev123) and on version on github. Signed-off-by: Arnaud Patard <apatard@hupstream.com>
ssbarnea
approved these changes
Oct 30, 2022
ssbarnea
added a commit
to ssbarnea/ansible-lint
that referenced
this pull request
Nov 11, 2022
This change is testing that get_version_warning(): - returns "" if current version is latest one - returns a pre-release information if using pre-release - returns a new release information and extra installation information. (note: this test doesn't check that guess_install_method() is working correctly) I had to use pytest-mock to ensure that all test parameters are correctly set. The test should not rely on current version (since it's likely v1.2.3dev123) and on version on github. Signed-off-by: Arnaud Patard <apatard@hupstream.com> Signed-off-by: Arnaud Patard <apatard@hupstream.com> Co-authored-by: Sorin Sbarnea <ssbarnea@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is testing that get_version_warning():
I had to use pytest-mock to ensure that all test parameters are correctly set. The test should not rely on current version (since it's likely v1.2.3dev123) and on version on github.
Signed-off-by: Arnaud Patard apatard@hupstream.com