Modules in roles included via 'import_role' are not detected

[drybjed]

Issue Type

• Bug report

Ansible and Ansible Lint details

ansible 2.9.1
  config file = None
  configured module search path = ['/home/drybjed/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/drybjed/.local/lib/python3.7/site-packages/ansible
  executable location = /home/drybjed/.local/bin/ansible
  python version = 3.7.3 (default, Apr  3 2019, 05:39:12) [GCC 8.3.0]

ansible-lint 4.2.0

• ansible installation method: pip
• ansible-lint installation method: pip

Desired Behaviour

I have a set of roles where one role (ansible_plugins) contains custom Ansible modules. Other roles that use these modules, include the ansible_plugins role using the import_role module, and role works fine, similarly to how the role with custom modules could be included via dependencies list in meta/main.yml file.

Actual Behaviour (Bug report only)

Currently using import_role instead of putting the role in dependencies results in ansible-lint not being able to detect the custom Ansible modules. This can be verified by running commands on a host with ansible-lint installed:

git clone https://github.com/debops/debops /tmp/debops && cd /tmp/debops
ansible-lint ansible/playbooks/service/cron.yml

The debops.cron role uses a custom dpkg_divert Ansible module which is included in the debops.ansible_plugins role. When the above command is executed, the result is:

Couldn't parse task at /tmp/debops/roles/debops.cron/tasks/main.yml:35 (couldn't resolve module/action 'dpkg_divert'. This often indicates a misspelling, missing collection, or incorrect module path.

The error appears to be in '<unicode string>': line 35, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

(could not open file to display line))
{ 'dpkg_divert': { '__file__': '/home/drybjed/debops/roles/debops.cron/tasks/main.yml',
                   '__line__': 36,
                   'delete': True,
                   'path': '/etc/crontab',
                   'state': '{{ cron__crontab_deploy_state }}'},
  'name': 'Divert the original crontab configuration',
  'skipped_rules': [],
  'tags': ['role::cron:crontab'],
  'when': "cron__enabled|bool and ansible_pkg_mgr == 'apt'"}

This setup works fine in Ansible itself.

[nqb]

Hello,

Any update on this issue ?

[fooka03]

As a workaround you could set ANSIBLE_LIBRARY to include the path to the imported role for the ansible-lint execution. We use this with our molecule linting:

lint: |
  set -e
  yamllint .
  ANSIBLE_LIBRARY=${MOLECULE_EPHEMERAL_DIRECTORY}/roles/<custom imported role>/library/:${MOLECULE_EPHEMERAL_DIRECTORY}/roles/<another custom imported role>/library/:${MOLECULE_EPHEMERAL_DIRECTORY}/library/:${MOLECULE_PROJECT_DIRECTORY}/library/ ansible-lint
  flake8

[geerlingguy]

I seem to be getting this when I use a module from a collection that is called from a module using its shortname if the module has the collection defined in the collections keyword inside the role's meta/main.yml. Works fine in the playbook but kills ansible-lint:

$ ansible-lint
Couldn't parse task at /Users/jgeerling/Development/GitHub/turing-pi-cluster/roles/minecraft/tasks/main.yml:9 (couldn't resolve module/action 'helm_repository'. This often indicates a misspelling, missing collection, or incorrect module path.

The error appears to be in '<unicode string>': line 9, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

(could not open file to display line))
{ 'helm_repository': { '__file__': '/Users/jgeerling/Development/GitHub/turing-pi-cluster/roles/minecraft/tasks/main.yml',
                       '__line__': 11,
                       'name': 'stable',
                       'repo_url': 'https://kubernetes-charts.storage.googleapis.com'},
  'name': 'Add stable chart repo.',
  'skipped_rules': []}

[miettal]

I seem to be getting this when I use a module from a collection that is called from a module using its shortname if the module has the collection defined in the collections keyword inside the role's meta/main.yml. Works fine in the playbook but kills ansible-lint:

I have the same issue.

// And ansible-lint doesn't seem to load "collection_path".

[ssbarnea]

Current error no longer reproduces with code from master branch, running ansible-lint ansible/playbooks/service/cron.yml returns success.