Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurse inside given folders #1302

Merged
merged 1 commit into from Feb 4, 2021
Merged

Recurse inside given folders #1302

merged 1 commit into from Feb 4, 2021

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Feb 3, 2021

When given folders, use the normal detection algorithm to look inside
them, making the outcome in sync with user expectations.

Fixes: #1241

@ssbarnea
Copy link
Member Author

ssbarnea commented Feb 3, 2021

@xoxys As this is fixing a bug your raised, I am hoping that you can manually test this patch and confirm that the new behavior is fixing it and not causing more confusions.

@xoxys
Copy link

xoxys commented Feb 3, 2021

Sure I'll give it a try later today.

When given folders, use the normal detection algorithm to look inside
them, making the outcome in sync with user expectations.

Fixes: #1241
@xoxys
Copy link

xoxys commented Feb 3, 2021

Yeah seems to work better now

@ssbarnea ssbarnea merged commit 4faa359 into master Feb 4, 2021
@ssbarnea ssbarnea deleted the 0/rc branch February 4, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent file list while loading files form args instead of a git repo
2 participants