Avoid creating .cache directory in cwd #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
0/wip
branch
2 times, most recently
from
d74213a
to
a3084cd
Compare
Instead of always using cwd for the .cache folder, we now try to use the project_dir for that, which defaults to the location of .ansiblelint config file. If there is no config file found and git fails to report a project root, it will use ~/.cache
aminvakil
reviewed
Mar 3, 2021
There was a problem hiding this comment.
I'm not sure what magic git you're running :) but on latest git installation (2.30.1) from https://git-scm.com/ there is no git ignore command as far as I know.
Edit: As far as I can tell other than this little documentation fix, everything else is ok.
Co-authored-by: Amin Vakil <info@aminvakil.com>
I do have few git extensions installed, sometimes I endup with mistakes like this. Thanks for reviewing it. |
aminvakil
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using cwd for the .cache folder, we now try to use the project_dir for that, which defaults to the location of
.ansiblelint config file.
Running ansible-lint from a subdirectory of the project, should no longer create .cache folders in new locations.
Execution outside a project or a git repository will make the linter use user home directory as reference,